linux-kernel - Re: [PATCH v2 1/2] staging: lustre: Reduce function visibility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Oct 2014 16:35:10 +0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Mariusz Gorski <marius.gorski@...il.com>
Cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Peng Tao <bergwolf@...il.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] staging: lustre: Reduce function visibility

On Sat, Oct 25, 2014 at 03:30:37AM +0200, Mariusz Gorski wrote:
> This patch fixes the following sparse warnings:
> drivers/staging/lustre/lnet/lnet/module.c:47:1: warning: symbol
>   'lnet_configure' was not declared. Should it be static?
> drivers/staging/lustre/lnet/lnet/module.c:67:1: warning: symbol
>   'lnet_unconfigure' was not declared. Should it be static?
> drivers/staging/lustre/lnet/lnet/module.c:87:1: warning: symbol
>   'lnet_ioctl' was not declared. Should it be static?
> drivers/staging/lustre/lnet/lnet/module.c:114:1: warning: symbol
>   'init_lnet' was not declared. Should it be static?
> drivers/staging/lustre/lnet/lnet/module.c:139:1: warning: symbol
>   'fini_lnet' was not declared. Should it be static?
> 
> Signed-off-by: Mariusz Gorski <marius.gorski@...il.com>
> ---
>  drivers/staging/lustre/lnet/lnet/module.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/module.c b/drivers/staging/lustre/lnet/lnet/module.c
> index e84d59d..dc09b43 100644
> --- a/drivers/staging/lustre/lnet/lnet/module.c
> +++ b/drivers/staging/lustre/lnet/lnet/module.c
> @@ -43,7 +43,7 @@ MODULE_PARM_DESC(config_on_load, "configure network at module load");
>  
>  static struct mutex lnet_config_mutex;
>  
> -int
> +static int
>  lnet_configure(void *arg)
>  {
>  	/* 'arg' only there so I can be passed to cfs_create_thread() */
> @@ -63,7 +63,7 @@ lnet_configure(void *arg)
>  	return rc;
>  }
>  
> -int
> +static int
>  lnet_unconfigure(void)
>  {
>  	int   refcount;
> @@ -83,7 +83,7 @@ lnet_unconfigure(void)
>  	return (refcount == 0) ? 0 : -EBUSY;
>  }
>  
> -int
> +static int
>  lnet_ioctl(unsigned int cmd, struct libcfs_ioctl_data *data)
>  {
>  	int   rc;
> @@ -110,7 +110,7 @@ lnet_ioctl(unsigned int cmd, struct libcfs_ioctl_data *data)
>  
>  DECLARE_IOCTL_HANDLER(lnet_ioctl_handler, lnet_ioctl);
>  
> -int
> +static int
>  init_lnet(void)
>  {
>  	int		  rc;
> @@ -135,7 +135,7 @@ init_lnet(void)
>  	return 0;
>  }
>  
> -void
> +static void
>  fini_lnet(void)
>  {
>  	int rc;

Someone did this patch before you, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/