linux-kernel - RE: [PATCH v1 1/3] firmware loader: Introduce new API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F54AEECA5E2B9541821D670476DAE19C2B80DB80@PGSMSX102.gar.corp.intel.com>
Date:	Wed, 29 Oct 2014 03:04:48 +0000
From:	"Kweh, Hock Leong" <hock.leong.kweh@...el.com>
To:	Ming Lei <ming.lei@...onical.com>
CC:	"Fleming, Matt" <matt.fleming@...el.com>,
	Sam Protsenko <semen.protsenko@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	"Ong, Boon Leong" <boon.leong.ong@...el.com>
Subject: RE: [PATCH v1 1/3] firmware loader: Introduce new API -
 request_firmware_abort()

> -----Original Message-----
> From: Ming Lei [mailto:ming.lei@...onical.com]
> Sent: Monday, October 27, 2014 12:00 AM
> 
> You can call fw_lookup_buf() directly, otherwise feel free to add:
> 
> Acked-by: Ming Lei <ming.lei@...onical.com>
> 

Hi Ming Lei,

The fw_lookup_buf() is defined inside the conditional preprocessor directive for CONFIG_PM_SLEEP.
Since the request_firmware_abort() may not only be used in PM_SLEEP, could I move the fw_lookup_buf()
out from the CONFIG_PM_SLEEP block if we want to call fw_lookup_buf() instead of __fw_lookup_buf()?

Thanks.


Regards,
Wilson