| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1414598634-13446-4-git-send-email-andrey.krieger.utkin@gmail.com> Date: Wed, 29 Oct 2014 20:03:54 +0400 From: Andrey Utkin <andrey.krieger.utkin@...il.com> To: linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, devel@...verdev.osuosl.org Cc: ismael.luceno@...p.bluecherry.net, m.chehab@...sung.com, hverkuil@...all.nl, Andrey Utkin <andrey.krieger.utkin@...il.com> Subject: [PATCH 4/4] [media] solo6x10: don't turn off/on encoder interrupt in processing loop The used approach actually cannot prevent new encoder interrupt to appear, because interrupt handler can execute in different thread, and in current implementation there is still race condition regarding this. Also from practice the code with this change seems to work as stable as before. Signed-off-by: Andrey Utkin <andrey.krieger.utkin@...il.com> --- drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c index b9b61b9..30e09d9 100644 --- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c @@ -703,9 +703,7 @@ static int solo_ring_thread(void *data) if (timeout == -ERESTARTSYS || kthread_should_stop()) break; - solo_irq_off(solo_dev, SOLO_IRQ_ENCODER); solo_handle_ring(solo_dev); - solo_irq_on(solo_dev, SOLO_IRQ_ENCODER); try_to_freeze(); } -- 1.8.5.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists