linux-kernel - Re: [PATCH v2] staging: skein: skein

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2014 00:05:53 +0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Mikael Svantesson <mikael@...topic.net>
Cc:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	devel@...verdev.osuosl.org, Jason Cooper <jason@...edaemon.net>,
	linux-kernel@...r.kernel.org, Jake Edge <jake@....net>,
	Anton Saraev <antonysaraev@...il.com>
Subject: Re: [PATCH v2] staging: skein: skein_api.c: removed space before ','

On Wed, Oct 29, 2014 at 08:25:30AM +0100, Mikael Svantesson wrote:
> Signed-off-by: Mikael Svantesson <mikael@...topic.net>
> ---
>  drivers/staging/skein/skein_api.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> index 6e700ee..5bfce07 100644
> --- a/drivers/staging/skein/skein_api.c
> +++ b/drivers/staging/skein/skein_api.c
> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
>  {
>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
>  
> -	memset(ctx , 0, sizeof(struct skein_ctx));
> +	memset(ctx, 0, sizeof(struct skein_ctx));
>  	ctx->skein_size = size;
>  
>  	return SKEIN_SUCCESS;
> -- 
> 2.1.1
> 
> On 2014-10-29 08:15, Mikael Svantesson wrote:
> > I'm saving the patch to my mail server using git-imap-send, then enter
> > e-mail addresses using Thunderbird and send it.
> > 
> > The problem seems to be that Thunderbird thrashes empty lines when
> > double clicking the e-mail in Drafts or selecting "Edit as new".
> > When forwarding the e-mail it doesn't seem to affect the empty lines,
> > very weird behaviour.
> > 
> > Regards,
> > 
> > Mikael
> > 
> > On 2014-10-29 06:25, Sudip Mukherjee wrote:
> >> On Tue, Oct 28, 2014 at 09:07:00PM +0100, Mikael Svantesson wrote:
> >>> Signed-off-by: Mikael Svantesson <mikael@...topic.net>
> >> still the same problem.
> >>
> >> ERROR: patch seems to be corrupt (line wrapped?)
> >>
> >>
> >>> ---
> >>>  drivers/staging/skein/skein_api.c | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/staging/skein/skein_api.c b/drivers/staging/skein/skein_api.c
> >>> index 6e700ee..5bfce07 100644
> >>> --- a/drivers/staging/skein/skein_api.c
> >>> +++ b/drivers/staging/skein/skein_api.c
> >>> @@ -31,7 +31,7 @@ int skein_ctx_prepare(struct skein_ctx *ctx, enum skein_size size)
> >>>  {
> >>>  	skein_assert_ret(ctx && size, SKEIN_FAIL);
> >>>  -	memset(ctx , 0, sizeof(struct skein_ctx));
> >>> +	memset(ctx, 0, sizeof(struct skein_ctx));
> >>>  	ctx->skein_size = size;
> >>>   	return SKEIN_SUCCESS;
> >>> -- 
> >>> 2.1.1
> >>>
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >>> the body of a message to majordomo@...r.kernel.org
> >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>> Please read the FAQ at  http://www.tux.org/lkml/
> > 

Please send this as a "correct" patch, not one with a whole bunch of
other stuff in it that I would have to hand-edit in order to apply
properly.

Remember, you want to make it as easy as possible for me to accept your
patches, so far, this isn't going well :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/