lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Oct 2014 20:12:49 +0100 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Josh Triplett <josh@...htriplett.org> Cc: Jonathan Corbet <corbet@....net>, "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] CodingStyle: Add a chapter on conditional compilation On Wed, Oct 29, 2014 at 7:15 PM, Josh Triplett <josh@...htriplett.org> wrote: > Document several common practices and conventions regarding conditional > compilation, most notably the preference for ifdefs in headers rather > than .c files. > > Signed-off-by: Josh Triplett <josh@...htriplett.org> > +If you have a function or variable which may potentially go unused in a > +particular configuration, and the compiler would warn about its definition > +going unused, mark the definition as __maybe_unused rather than wrapping it in > +a preprocessor conditional. (However, if a function or variable *always* goes > +unused, delete it.) Personally, I don't like __maybe_unused. Once it's there, the compiler will stop warning about it, even if it really becomes unused. Apart from that: Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists