linux-kernel - [RFC] stating: ion: use hot page first in pool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <545073AB.5060502@lge.com>
Date:	Wed, 29 Oct 2014 13:57:15 +0900
From:	Gioh Kim <gioh.kim@....com>
To:	gregkh@...uxfoundation.org, john.stultz@...aro.org,
	rebecca@...roid.com, lauraa@...eaurora.org,
	dan.carpenter@...cle.com, Minchan Kim <minchan@...nel.org>,
	'김준수' <iamjoonsoo.kim@....com>
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	gunho.lee@....com, gioh.kim@....com
Subject: [RFC] stating: ion: use hot page first in pool


Hello,

I found that ion insert freed-page at the tail of list
and extract at the head.

I think it is good for cache to use the most recently used page
but these pages in pool are not cached memory.
So I'm not sure using hot page is better or not in this case.

What do you think about using hot page first?

-------------------------- 8< -----------------------------

>From 14c8455cc80628e56a27ace9603d29e5056835b5 Mon Sep 17 00:00:00 2001
From: Gioh Kim <gioh.kim@....com>
Date: Wed, 29 Oct 2014 13:44:28 +0900
Subject: [PATCH] staging: ion: use hot-page first

A page near the head is hot for cache.
This patch makes pool use hot page first.

Signed-off-by: Gioh Kim <gioh.kim@....com>
---
 drivers/staging/android/ion/ion_page_pool.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
index 5864f3d..3d6ac4f 100644
--- a/drivers/staging/android/ion/ion_page_pool.c
+++ b/drivers/staging/android/ion/ion_page_pool.c
@@ -45,10 +45,10 @@ static int ion_page_pool_add(struct ion_page_pool *pool, struct page *page)
 {
        mutex_lock(&pool->mutex);
        if (PageHighMem(page)) {
-               list_add_tail(&page->lru, &pool->high_items);
+               list_add(&page->lru, &pool->high_items);
                pool->high_count++;
        } else {
-               list_add_tail(&page->lru, &pool->low_items);
+               list_add(&page->lru, &pool->low_items);
                pool->low_count++;
        }
        mutex_unlock(&pool->mutex);
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/