[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20141030054208.GE7996@ZenIV.linux.org.uk>
Date: Thu, 30 Oct 2014 05:42:09 +0000
From: Al Viro <viro@...IV.linux.org.uk>
To: Kent Overstreet <kmo@...erainc.com>
Cc: linux-kernel@...r.kernel.org, linux-bcache@...r.kernel.org
Subject: [PATCH] fix a leak in bch_cached_dev_run()
Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -878,8 +878,11 @@ void bch_cached_dev_run(struct cached_dev *dc)
buf[SB_LABEL_SIZE] = '\0';
env[2] = kasprintf(GFP_KERNEL, "CACHED_LABEL=%s", buf);
- if (atomic_xchg(&dc->running, 1))
+ if (atomic_xchg(&dc->running, 1)) {
+ kfree(env[1]);
+ kfree(env[2]);
return;
+ }
if (!d->c &&
BDEV_STATE(&dc->sb) != BDEV_STATE_NONE) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists