linux-kernel - Re: [PATCH] Add ltc3562 voltage regulator driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141030101555.GT18557@sirena.org.uk>
Date:	Thu, 30 Oct 2014 10:15:55 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Mike Looijmans <mike.looijmans@...ic.nl>
Cc:	lgirdwood@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add ltc3562 voltage regulator driver

On Thu, Oct 30, 2014 at 07:47:44AM +0100, Mike Looijmans wrote:
> On 10/29/2014 01:30 PM, Mark Brown wrote:

> >A couple of problems here:

> >  - This contains DT code but no DT bindings documentation; the binding
> >    documentation is mandatory for any new bindings.

> Should I submit a new patch to add the DT bindings and CC to the dt mailing
> list, or do you want it included in this patch? I was basically waiting for
> feedback on the driver first.

I'm not going to review a driver with bindings without those bindings
being documented, it's a well documented requirement and apart from
anything else it's not really possible to review the code that manages
the bindings without seeing the bindings.

> The "default voltage" may not be device specific, but regulator.txt doesn't
> have a property that describes what we needed here, because we can't get
> away with specifying min=max as fixed-regulator does. We also cannot assume
> that default=min or default=max, because that might harm hardware connected
> to the other side of the IO bank.

No, if you need a generic property add it in the generic code rather
than just hacking a device specific property into your driver.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)