linux-kernel - [RFC PATCH v2 00/11] Convert do_settimeofday() to use timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2014 19:15:34 +0800
From:	"pang.xunlei" <pang.xunlei@...aro.org>
To:	linux-kernel@...r.kernel.org
Cc:	rtc-linux@...glegroups.com, xen-devel@...ts.xenproject.org,
	John Stultz <john.stultz@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	"pang.xunlei" <pang.xunlei@...aro.org>
Subject: [RFC PATCH v2 00/11] Convert do_settimeofday() to use timespec64

The kernel uses 32-bit signed value(time_t) for seconds since 
1970-01-01:00:00:00, so it will overflow at 2038-01-19 03:14:08 on 
32-bit systems. We call this "2038 safety" issue.

Currently, I'm working with "John Stultz" to deal with this issue.

This series doesn't involve any functional change, and mainly converts 
do_settimeofday() to use timespec64(By adding new do_settimeofday64() 
using timespec64). During the conversion, it needs to handle mktime(), 
rtc_tm_to_time(), rtc_time_to_tm() and other functions similarly due 
to dependencies.

The main processing logic here is:
Add xxx64() safe version:
	*Add do_settimeofday64() safe version(using timespec64)
	*Add mktime64() safe version(using time64_t)
	*Add rtc_tm_to_time64() safe version(using time64_t)
	*Add rtc_time_to_tm64() safe version(using time64_t)

Clean unsafe do_settimeofday():
	*Convert all users of do_settimeofday() to use do_settimeofday64()
	*Remove do_settimeofday()
	*Try the best to eliminate TODOs brought by these patches

Clean unsafe mktime()/rtc_tm_to_time()/rtc_time_to_tm() respectively:
	*Convert all users of xxx() to use xxx64() one by one
	*Try the best to eliminate TODOs brought by these patches
	*Remove xxx()

So the rest of this patch series does tons of work on these conversions.

NOTE: This series actually contains 153 patches in total, but just sent
out a small subset here for feedback to make sure there are no objections
with my approach. 

Please access the link below for all the related patches if interested:
https://git.linaro.org/people/pang.xunlei/linuxstable.git

pang.xunlei (11):
  time: Add do_settimeofday64() safe version(using timespec64)
  time: Add mktime64() safe version(using time64_t)
  time: Add rtc_tm_to_time64() safe version(using time64_t)
  time: Add rtc_time_to_tm64() safe version(using time64_t)
  time: Convert all users of do_settimeofday() to use
    do_settimeofday64()
  time: Remove do_settimeofday()
  time: Convert alarm_set_rtc() to use timespec64
  time: Convert xen_read_wallclock() to use timespec64
  time: Convert pvclock_read_wallclock() to use timespec64
  time: Convert x86_platform.set_wallclock()to use timespec64
  time: Convert x86_platform.get_wallclock()to use timespec64

 arch/x86/include/asm/intel_mid_vrtc.h        |    4 +-
 arch/x86/include/asm/mc146818rtc.h           |    4 +-
 arch/x86/include/asm/pvclock.h               |    2 +-
 arch/x86/include/asm/x86_init.h              |   11 ++++--
 arch/x86/kernel/kvmclock.c                   |    6 +--
 arch/x86/kernel/pvclock.c                    |    9 +++--
 arch/x86/kernel/rtc.c                        |   30 ++++++++++-----
 arch/x86/lguest/boot.c                       |    4 +-
 arch/x86/platform/intel-mid/intel_mid_vrtc.c |   12 +++---
 arch/x86/xen/time.c                          |   13 +++----
 drivers/hv/hv_util.c                         |    6 +--
 drivers/rtc/hctosys.c                        |   10 ++---
 drivers/rtc/rtc-lib.c                        |   35 ++++++++++++++---
 drivers/staging/android/alarm-dev.c          |   14 +++++--
 include/linux/lguest.h                       |    2 +-
 include/linux/rtc.h                          |    2 +
 include/linux/time.h                         |    4 ++
 include/linux/time64.h                       |    5 ++-
 include/linux/timekeeping.h                  |    2 +-
 kernel/compat.c                              |    5 ++-
 kernel/time/time.c                           |   52 ++++++++++++++++++++++++--
 kernel/time/timekeeping.c                    |   20 +++++-----
 22 files changed, 176 insertions(+), 76 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/