linux-kernel - Re: I2C OF IRQ parsing issue due to probe ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15051800.BQpGCgk7GR@avalon>
Date:	Thu, 30 Oct 2014 14:15:43 +0200
From:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Cc:	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-gpio@...r.kernel.org, Wolfram Sang <wsa@...-dreams.de>,
	Thierry Reding <thierry.reding@...il.com>
Subject: Re: I2C OF IRQ parsing issue due to probe ordering

Hi Ezequiel,

On Thursday 30 October 2014 08:58:28 Ezequiel Garcia wrote:
> On 10/25/2014 07:13 PM, Laurent Pinchart wrote:
> > Hello,
> > 
> > I recently ran into an issue with the OF IRQ parsing code in the I2C core
> > (of_i2c_register_devices in drivers/i2c/i2c-core.c).
> > 
> > My DT contains the following nodes.
> > 
> >         gpio1: gpio@...51000 {
> >                 ...
> >                 #interrupt-cells = <2>;
> >                 interrupt-controller;
> >                 clocks = <&mstp9_clks R8A7790_CLK_GPIO1>;
> >         };
> >         
> >         iic2: i2c@...20000 {
> >                 #address-cells = <1>;
> >                 #size-cells = <0>;
> >                 ...
> >                 hdmi@39 {
> >                         compatible = "adi,adv7511w";
> >                         reg = <0x39>;
> >                         interrupt-parent = <&gpio1>;
> >                         interrupts = <15 IRQ_TYPE_EDGE_FALLING>;
> >                         ...
> >                 };
> >         };
> >         
> >         mstp9_clks: mstp9_clks@...50994 {
> >                 ...
> >         };
> > 
> > The i2c@...20000 node is probed before the gpio@...51000 node. The
> > of_i2c_register_devices() function tries to register all children,
> > including hdmi@39. It tries to parse and map the I2C client IRQ by
> > calling irq_of_parse_and_map(), which returns 0 as the interrupt
> > controller isn't probed yet. The adv7511 driver later probes the hdmi@39
> > device and gets client->irq set to 0.
> > 
> > We can't control the probe order.
> 
> Maybe I'm missing something, but I think your i2c adapter is probed with
> a subsys_initcall (as many other adapters). Otherwise, I can't see why
> it would be probed before the the gpio controller.
> 
> I think this initcall is your problem. Have you tried just using
> platform_driver's probe?

My I2C controller driver uses module_platform_driver(). The reason why the 
GPIO controller is probed later is because the GPIO requires a clock, and the 
clock device is probed after the I2C controller, resulting in a deferred 
probing the first time the GPIO controller is probed.

In the general case probe ordering can't be controlled, especially with DT. I 
believe we thus need a generic solution.

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/