linux-kernel - Re: I2C OF IRQ parsing issue due to probe ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 30 Oct 2014 14:43:57 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Wolfram Sang <wsa@...-dreams.de>, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: I2C OF IRQ parsing issue due to probe ordering

On Thu, Oct 30, 2014 at 03:22:49PM +0200, Laurent Pinchart wrote:
> Hi Wolfram,
> 
> On Thursday 30 October 2014 14:21:36 Wolfram Sang wrote:
> > > > See:
> > > > 	9ec36cafe43b of/irq: do irq resolution in platform_get_irq
> > > > 
> > > > I suspect a similar thing could be done for I2C.
> > > 
> > > That could work. We would need to introduce a new i2c_get_irq() function
> > > though. Wolfram, would you be fine with that ?
> > 
> > I'd think it will look pretty similar to platform_get_irq, no? That is
> > fine with me.
> 
> It would, but as Thierry pointed out it should be possible to hide the details 
> in the I2C core. I'll submit a patch shortly.

i2c_device_probe() seems exactly the right place to do this. It's in
fact the equivalent of what I had proposed in my original patch series
where this was done in platform_drv_probe().

Thierry

Content of type "application/pgp-signature" skipped