lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Oct 2014 15:14:17 +0100 From: Arnd Bergmann <arnd@...db.de> To: balbi@...com Cc: Huang Rui <ray.huang@....com>, Alan Stern <stern@...land.harvard.edu>, Bjorn Helgaas <bhelgaas@...gle.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Paul Zimmerman <Paul.Zimmerman@...opsys.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Sergei Shtylyov <sergei.shtylyov@...entembedded.com>, Jason Chang <jason.chang@....com>, Vincent Wan <vincent.wan@....com>, Tony Li <tony.li@....com>, linux-usb@...r.kernel.org, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org Subject: Re: [PATCH v4 01/20] usb: dwc3: enable hibernation if to be supported On Thursday 30 October 2014 09:08:32 Felipe Balbi wrote: > On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: > > On Thursday 30 October 2014 18:08:26 Huang Rui wrote: > > > It enables hibernation if the function is set in coreConsultant. > > > > > > Suggested-by: Felipe Balbi <balbi@...com> > > > Signed-off-by: Huang Rui <ray.huang@....com> > > > Signed-off-by: Felipe Balbi <balbi@...com> > > > > > > > Something went wrong with the Signed-off-by lines here. > > You should never add someone else's Signed-off-by below yours. > > > > I took a brief look at the entire series and the patches all look good > > to me, but you have made the same mistake with the Signed-off-by > > multiple times. > > there are no mistakes, I just asked Huang to resend what I had on my > testing/next because it had not been sent to devicetree mailing list. > It's definitely a tricky question what the right Signed-off-by chain is in this case, I guess strictly speaking it could have been Suggested-by: Felipe Balbi <balbi@...com> Signed-off-by: Huang Rui <ray.huang@....com> Signed-off-by: Felipe Balbi <balbi@...com> Signed-off-by: Huang Rui <ray.huang@....com> which could correctly track where the patches went, but it's also somewhat silly. I would probably just have dropped the second Signed-off-by, so that the last S-o-b in the patch matches the "From", as we expect. It's definitely good to know that Huang Rui was not faking your Signed-off-by but that you had actually provided it yourself. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists