linux-kernel - Re: [PATCH] watchdog: at91rm9200: allow building when using device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141030151719.GG17398@piout.net>
Date:	Thu, 30 Oct 2014 16:17:19 +0100
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Wim Van Sebroeck <wim@...ana.be>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] watchdog: at91rm9200: allow building when using device
 tree

On 30/10/2014 at 15:43:43 +0100, Arnd Bergmann wrote :
> On Thursday 30 October 2014 15:36:24 Boris Brezillon wrote:
> > On Thu, 30 Oct 2014 15:15:34 +0100
> > Alexandre Belloni <alexandre.belloni@...e-electrons.com> wrote:
> > 
> > > When building with device tree, ARCH_AT91RM9200 may not be selected. Allow
> > > building that driver by also depending on ARCH_AT91.
> > > 
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> > 
> > Acked-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> > 
> 
> Doesn't this reintroduce the bug fixed by commit 09549cd0172 ("watchdog:
> Revert the AT91RM9200_WATCHDOG dependency")?
> 
> At least in 3.18-rc2, the driver still uses at91_st_write/at91_st_read.
> 

Hum, right, then we have no better way to express that than depends on
SOC_AT91RM9200, would that be acceptable ?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/