linux-kernel - Re: [PATCH] PCI: fix name of 'enable' sysfs file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141030165648.GA7402@kroah.com>
Date:	Thu, 30 Oct 2014 09:56:48 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Bjorn Helgaas <bhelgaas@...gle.com>,
	Jeff Epler <jepler@...ythonic.net>, linux-pci@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: fix name of 'enable' sysfs file

On Thu, Oct 30, 2014 at 05:50:41PM +0100, Jiri Kosina wrote:
> On Thu, 30 Oct 2014, Greg Kroah-Hartman wrote:
> 
> > From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > 
> > Back in commit 5136b2da770d ("PCI: convert bus code to use dev_groups"),
> > I misstyped the 'enable' sysfs file as 'enabled', which broke the
> > userspace api.  This patch fixes that issue by renaming the file back.
> 
> But this is in turn 3.13 -> 3.18 userspace interface breakage ... I don't 
> think there is other graceful way out of this than creating a symlink so 
> that both variants work, right?

Given that no one noticed that this was broken until now, I really doubt
that anyone wrote code for the new file name.  I recommend just fixing
it back, and getting it into all stable kernel trees and moving on.

A symlink for such a foolish mistake seems like a bigger mistake :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/