linux-kernel - Re: [RFC] arm:remove clear_thread_flag(TIF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1414742289.8928.5.camel@perches.com>
Date:	Fri, 31 Oct 2014 00:58:09 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Wang, Yalin" <Yalin.Wang@...ymobile.com>
Cc:	'Will Deacon' <will.deacon@....com>,
	'Ard Biesheuvel' <ard.biesheuvel@...aro.org>,
	'Russell King - ARM Linux' <linux@....linux.org.uk>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"'akinobu.mita@...il.com'" <akinobu.mita@...il.com>,
	"'linux-mm@...ck.org'" <linux-mm@...ck.org>,
	"'linux-arm-kernel@...ts.infradead.org'" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [RFC] arm:remove clear_thread_flag(TIF_UPROBE)

On Fri, 2014-10-31 at 15:51 +0800, Wang, Yalin wrote:
> > From: Joe Perches [mailto:joe@...ches.com]
> > > diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c
> > []
> > > @@ -591,10 +591,9 @@ do_work_pending(struct pt_regs *regs, unsigned int
> > thread_flags, int syscall)
> > >  					return restart;
> > >  				}
> > >  				syscall = 0;
> > > -			} else if (thread_flags & _TIF_UPROBE) {
> > > -				clear_thread_flag(TIF_UPROBE);
> > > +			} else if (thread_flags & _TIF_UPROBE)
> > >  				uprobe_notify_resume(regs);
> > > -			} else {
> > > +			else {
> > >  				clear_thread_flag(TIF_NOTIFY_RESUME);
> > >  				tracehook_notify_resume(regs);
> > >  			}
> > 
> > Please keep the braces.
> 
> mm..  could I know the reason ?  :)

Try read Documentation/CodingStyle

		Chapter 3: Placing Braces and Spaces

use braces in both branches:

if (condition) {
	do_this();
	do_that();
} else {
	otherwise();
}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/