linux-kernel - Re: [PATCH v5 07/12] leds: leds-gpio: Add support for GPIO descriptors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYQwzwLJOCx76uONCpTsUtxhePaByyYPz-52Xw9L+DYQQ@mail.gmail.com>
Date:	Fri, 31 Oct 2014 10:41:38 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Grant Likely <grant.likely@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	Aaron Lu <aaron.lu@...el.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Alexandre Courbot <gnurou@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Bryan Wu <cooloney@...il.com>,
	Darren Hart <dvhart@...ux.intel.com>,
	Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH v5 07/12] leds: leds-gpio: Add support for GPIO descriptors

On Thu, Oct 30, 2014 at 5:15 PM, Mika Westerberg
<mika.westerberg@...ux.intel.com> wrote:
> On Thu, Oct 30, 2014 at 04:40:05PM +0100, Linus Walleij wrote:
>> > Yes, I'll just let dust to settle before sending out a patch that
>> > converts the existing users of platform_gpio_blink_set() callback to
>> > gpio descriptors.
>>
>> Dust settle = 2 weeks, 18 months, 5 years?
>
> I started to do the conversion already but then noticed that it is not
> that trivial after all.

Thanks for looking into this.

> For example we have one user in arch/arm/mach-orion5x/dns323-setup.c:
>
> static struct gpio_led_platform_data dns323ab_led_data = {
>         .num_leds       = ARRAY_SIZE(dns323ab_leds),
>         .leds           = dns323ab_leds,
>         .gpio_blink_set = orion_gpio_led_blink_set,
> };
>
> orion_gpio_led_blink_set() is part of orion specific custom GPIO
> "driver" defined in arch/arm/plat-orion/gpio.c and as far as I can tell
> cannot use GPIO descriptors as it directly programs these numbers to the
> hardware.
>
> We can convert the descriptor to a number in the beginning of
> orion_gpio_led_blink_set() if that helps.
>
> Other two users: rx1950_led_blink_set() and h1940_led_blink_set() seem
> to have similar needs for the numeric value.

Doing the conversion from descriptor to gpio number in the
platforms is *much desired*, because it is a nice divide-and-conquer
approach.

For example mach-orion is going to be deleted and replaced
with mach-mvebu at some time, so then part of the problem
goes away entirely.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/