linux-kernel - Re: [PATCH 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABuKBeKuDYDdHhbatCNREpeaGH=c0FBRiyqpaRmDjZAYTxoWCw@mail.gmail.com>
Date:	Fri, 31 Oct 2014 11:50:23 +0100
From:	Matthias Brugger <matthias.bgg@...il.com>
To:	xudong chen <xudong.chen@...iatek.com>
Cc:	Mark Rutland <mark.rutland@....com>, arm@...nel.org,
	Wolfram Sang <wsa@...-dreams.de>,
	srv_heupstream <srv_heupstream@...iatek.com>,
	Sascha Hauer <kernel@...gutronix.de>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Russell King <linux@....linux.org.uk>,
	Grant Likely <grant.likely@...aro.org>,
	Jean Delvare <jdelvare@...e.de>, Arnd Bergmann <arnd@...db.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>, linux-i2c@...r.kernel.org,
	Yingjoe Chen <yingjoe.chen@...iatek.com>,
	Eddie Huang <eddie.huang@...iatek.com>,
	Nathan Chung <nathan.chung@...iatek.com>,
	YH Chen <yh.chen@...iatek.com>
Subject: Re: [PATCH 1/3] dt-bindings: Add I2C bindings for mt65xx/mt81xx.

2014-10-31 2:38 GMT+01:00 xudong chen <xudong.chen@...iatek.com>:
> On Thu, 2014-10-30 at 13:38 +0100, Matthias Brugger wrote:
>> 2014-10-29 6:37 GMT+01:00 Xudong Chen <xudong.chen@...iatek.com>:
>> > Add devicetree bindings for Mediatek Soc I2C driver.
>> >
>> > Signed-off-by: Xudong Chen <xudong.chen@...iatek.com>
>> > ---
>> >  .../devicetree/bindings/i2c/i2c-mt6577.txt         | 37 ++++++++++++++++++++++
>> >  1 file changed, 37 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
>> >
>> > diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
>> > new file mode 100644
>> > index 0000000..b4012c8
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt
>> > @@ -0,0 +1,37 @@
>> > +* Mediatek's I2C controller
>> > +
>> > +The Mediatek's I2C controller is used to interface with I2C devices.
>> > +
>> > +Required properties:
>> > +  - compatible: value should be either of the following.
>> > +      (a) "mtk,mt6577-i2c", for i2c compatible with mt6577 i2c.
>>
>> Looking on the datasheet of mt6577 it does not seem that this driver
>> is really compatible.
>> I was not able to find the PATH_DIR register neither in the datasheet
>> nor in the source code.
>>
> Hi,
>
> The PATH_DIR register named OFFSET_PATH_DIR(0x60) in the source code.
> Only MT8135 supports this feature, so it does not contained in mt6577
> datasheet.
> I will modify the comment.
>
>> > +      (b) "mtk,mt8127-i2c", for i2c compatible with mt8127 i2c.
>> > +      (c) "mtk,mt8135-i2c", for i2c compatible with mt8135 i2c.
>> > +  - reg: physical base address of the controller and dma base, length of memory mapped
>> > +    region.
>> > +  - interrupts: interrupt number to the cpu.
>> > +  - clock-div: the fixed value for frequency divider of clock source in i2c module.
>> > +    Each IC may be different.
>> > +  - clocks: clock name from clock manager
>> > +  - clock-names: clock name used in i2c driver probe
>> > +
>> > +Optional properties:
>> > +  - clock-frequency: Frequency in Hz of the bus when transfer, the default value is 100000.
>> > +  - mediatek,have-pmic: platform can control i2c form special pmic side.
>
> I will change this to:
>  - mediatek,have-pmic: platform can control i2c form special pmic side,
> only MT8135 supports this.
>
> Is this OK?

We need a multi function device driver for the I2C and the PMIC.
Please have a look on my comments in the other thread.

Thanks,
Matthias

>
>> > +  - mediatek,have-dcm: platform has DCM(hardware digital clock manager) property.
>> > +  - mediatek,use-push-pull: IO use push-pull mode.
>> > +
>> > +Example:
>> > +
>> > +       i2c0: i2c@...0d000 {
>> > +                       compatible = "mediatek,mt6577-i2c";
>> > +                       reg = <0x1100d000 0x70>,
>> > +                             <0x11000300 0x80>;
>> > +                       interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
>> > +                       clock-frequency = <100000>;
>> > +                       mediatek,have-pmic;
>> > +                       clock-div = <16>;
>> > +                       clocks = <&i2c0_ck>, <&ap_dma_ck>;
>> > +                       clock-names = "main", "dma";
>> > +       };
>> > +
>> > --
>> > 1.8.1.1.dirty
>> >
>>
>>
>>
>
>



-- 
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/