| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1414758561-30022-1-git-send-email-sudipm.mukherjee@gmail.com> Date: Fri, 31 Oct 2014 17:59:21 +0530 From: Sudip Mukherjee <sudipm.mukherjee@...il.com> To: Mark Fasheh <mfasheh@...e.com>, Joel Becker <jlbec@...lplan.org> Cc: Sudip Mukherjee <sudipm.mukherjee@...il.com>, ocfs2-devel@....oracle.com, linux-kernel@...r.kernel.org, Weiwei Wang <wangww631@...wei.com> Subject: [PATCH] ocfs2: improve code readability code was getting confusing as the priority of both the operators ! and & are same. this change is done to just to improve the readability of the code. Signed-off-by: Sudip Mukherjee <sudip@...torindia.org> --- hi, i hope this is the way Weiwei Wang has thought of the logic when giving that BUG_ON, please discard this patch if this assumption was worng. fs/ocfs2/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index 62620ab..1a05574 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -2764,7 +2764,7 @@ int ocfs2_del_inode_from_orphan(struct ocfs2_super *osb, goto bail_unlock_orphan; } - BUG_ON(!di->i_flags & cpu_to_le32(OCFS2_DIO_ORPHANED_FL)); + BUG_ON(!(di->i_flags & cpu_to_le32(OCFS2_DIO_ORPHANED_FL))); /* Only delete entry if OCFS2_ORPHANED_FL not set, or * there are two entries added */ -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists