linux-kernel - Re: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141031134951.GG1273@saruman>
Date:	Fri, 31 Oct 2014 08:49:51 -0500
From:	Felipe Balbi <balbi@...com>
To:	Kever Yang <kever.yang@...k-chips.com>
CC:	<dinguyen@...nsource.altera.com>, <paulz@...opsys.com>,
	<balbi@...com>, <dinh.linux@...il.com>, <swarren@...dotorg.org>,
	<b.zolnierkie@...sung.com>, <matthijs@...in.nl>,
	<r.baldyga@...sung.com>, <jg1.han@...sung.com>,
	<sachin.kamat@...aro.org>, <ben-linux@...ff.org>,
	<dianders@...omium.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there
 isn't a clock node

On Fri, Oct 31, 2014 at 10:38:28AM +0800, Kever Yang wrote:
> Hi Dinh,
> 
> On 10/29/2014 07:25 AM, dinguyen@...nsource.altera.com wrote:
> >From: Dinh Nguyen <dinguyen@...nsource.altera.com>
> >
> >Since the dwc2 hcd driver is currently not looking for a clock node during
> >init, we should not completely fail if there isn't a clock provided.
> >For dual-role mode, we will only fail init for a non-clock node error. We
> >then update the HCD to only call gadget funtions if there is a proper clock
> >node.
> We have to add clock management for hcd, and I think it is better to
> do it before more Socs use this driver, isn't it?
> I have do something in my RFC patches, but I think I still do it in a wrong
> way.
> Can we just handle all the clock thing in platform?
> 
> Balbi suggested in my patch that we can "hide" clk_enable()/disable() under
> ->runtime_resume()/->runtime_suspend() and linux driver model.
> Can this be in platform driver?

it can and it probably should. Implement
->runtime_resume()/->runtime_suspend()/runtime_idle() in platform.c and
call pm_runtime_enable()/get()/put()/mark_last_busy()/autosuspend()
properly.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)