linux-kernel - Re: [PATCH] Frontswap: fix the condition in BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141031141013.GH4704@laptop.dumpdata.com>
Date:	Fri, 31 Oct 2014 10:10:13 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Li Haifeng <omycle@...il.com>, akpm@...ux-foundation.org
Cc:	open list <linux-kernel@...r.kernel.org>,
	"open list:MEMORY MANAGEMENT" <linux-mm@...ck.org>
Subject: Re: [PATCH] Frontswap: fix the condition in BUG_ON

On Fri, Oct 31, 2014 at 06:14:19PM +0800, Li Haifeng wrote:
> >From 012a564c7210346b99d12e3d2485542bb090586e Mon Sep 17 00:00:00 2001
> From: Haifeng Li <omycle@...il.com>
> Date: Fri, 31 Oct 2014 17:40:44 +0800
> Subject: [PATCH] Frontswap: fix the condition in BUG_ON
> 
> The largest index of swap device is MAX_SWAPFILES-1. So the type
> should be less than MAX_SWAPFILES.

Ok, so we would never hit this BUG_ON because of that.

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>

P.S.
Andrew - are you OK picking this up?

Thank you!
> 
> Signed-off-by: Haifeng Li <omycle@...il.com>
> ---
>  mm/frontswap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/frontswap.c b/mm/frontswap.c
> index c30eec5..1b80c05 100644
> --- a/mm/frontswap.c
> +++ b/mm/frontswap.c
> @@ -182,7 +182,7 @@ void __frontswap_init(unsigned type, unsigned long *map)
>         if (frontswap_ops)
>                 frontswap_ops->init(type);
>         else {
> -               BUG_ON(type > MAX_SWAPFILES);
> +               BUG_ON(type >= MAX_SWAPFILES);
>                 set_bit(type, need_init);
>         }
>  }
> -- 
> 1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/