linux-kernel - Re: [PATCH] isofs: remove unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141031144045.GA10437@quack.suse.cz>
Date:	Fri, 31 Oct 2014 15:40:45 +0100
From:	Jan Kara <jack@...e.cz>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Fabian Frederick <fabf@...net.be>,
	Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] isofs: remove unused functions

On Fri 31-10-14 17:43:48, Sudip Mukherjee wrote:
> commit "5b71ecfa78271d5c576f17156ed8a53981c1ecbb" removed the use
> two functions isofs_hash() and isofs_dentry_cmp() , but their
> definition was not removed.
> So, as these functions are not used anywhere so it is safe to
> remove them. It has been build tested after removing.
  Thanks for the patch. One note though - after your patch
isofs_hash_common() is called from a single place so there's no point to
have that function. You can just inline it in isofs_hash_ms(). Please do
that when we are messing with the code.

								Honza
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
>  fs/isofs/inode.c | 17 -----------------
>  1 file changed, 17 deletions(-)
> 
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index 859a309..fe839b9 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -29,13 +29,9 @@
>  #define BEQUIET
>  
>  static int isofs_hashi(const struct dentry *parent, struct qstr *qstr);
> -static int isofs_hash(const struct dentry *parent, struct qstr *qstr);
>  static int isofs_dentry_cmpi(const struct dentry *parent,
>  		const struct dentry *dentry,
>  		unsigned int len, const char *str, const struct qstr *name);
> -static int isofs_dentry_cmp(const struct dentry *parent,
> -		const struct dentry *dentry,
> -		unsigned int len, const char *str, const struct qstr *name);
>  
>  #ifdef CONFIG_JOLIET
>  static int isofs_hashi_ms(const struct dentry *parent, struct qstr *qstr);
> @@ -254,25 +250,12 @@ static int isofs_dentry_cmp_common(
>  }
>  
>  static int
> -isofs_hash(const struct dentry *dentry, struct qstr *qstr)
> -{
> -	return isofs_hash_common(qstr, 0);
> -}
> -
> -static int
>  isofs_hashi(const struct dentry *dentry, struct qstr *qstr)
>  {
>  	return isofs_hashi_common(qstr, 0);
>  }
>  
>  static int
> -isofs_dentry_cmp(const struct dentry *parent, const struct dentry *dentry,
> -		unsigned int len, const char *str, const struct qstr *name)
> -{
> -	return isofs_dentry_cmp_common(len, str, name, 0, 0);
> -}
> -
> -static int
>  isofs_dentry_cmpi(const struct dentry *parent, const struct dentry *dentry,
>  		unsigned int len, const char *str, const struct qstr *name)
>  {
> -- 
> 1.8.1.2
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/