linux-kernel - Re: WARNING at fs/nfs/write.c:743 nfs_inode_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141031145528.GI6731@arm.com>
Date:	Fri, 31 Oct 2014 14:55:28 +0000
From:	Will Deacon <will.deacon@....com>
To:	Weston Andros Adamson <dros@...marydata.com>
Cc:	Peng Tao <tao.peng@...marydata.com>,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	linux-nfs list <linux-nfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: WARNING at fs/nfs/write.c:743 nfs_inode_remove_request with -rc6

On Fri, Oct 31, 2014 at 02:49:13PM +0000, Weston Andros Adamson wrote:
> On Oct 20, 2014, at 9:57 AM, Will Deacon <will.deacon@....com> wrote:
> > On Sat, Oct 11, 2014 at 02:32:29PM +0100, Weston Andros Adamson wrote:
> >> I’ve been very busy, but I haven’t forgotten about your bug report!
> > 
> > No problem, I've been busy too. I just checked with -rc1 and I can reproduce
> > the issue there too.
> > 
> >> I think the WARN_ON_ONCE is just wrong, there are cases where the
> >> PG_INODE_REF flag is legitimately not set. The flag is set so that sub
> >> requests can mimmic the parent request’s reference count.
> >> 
> >> Could you please run the reproducer again, unmount, then check the contents of
> >> /proc/fs/nfsfs/servers?
> > 
> > Sure. I just tried this and that file is empty after unmounting.
> 
> Sorry for the delay (again) - I just got back from a two week holiday.
> 
> This is good news! I think we can safely remove this WARN_ON_ONCE and call it a
> day… or maybe calling it a month is more accurate ;)

Great! Feel free to add my reported-by/tested-by on that patch.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/