linux-kernel - Re: [PATCH] x86, boot: add hex output for debugging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141031174251.GM3274@tassilo.jf.intel.com>
Date:	Fri, 31 Oct 2014 10:42:51 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Vivek Goyal <vgoyal@...hat.com>,
	Junjie Mao <eternal.n08@...il.com>
Subject: Re: [PATCH] x86, boot: add hex output for debugging

> > +void __puthex(unsigned long value)
> > +{
> > +	char alpha[2] = "0";
> > +	int bits;
> > +	unsigned char byte;
> 
> what is 'byte' for?  (unused)

Well the whole function is unused. We don't normally add unused functions
to the code because they bitrot too easily.

If you need it please just patch it in yourself.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/