linux-kernel - Re: [PATCH] kbuild: collect shorthands into the top Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20141031111254.8FF3.AA925319@jp.panasonic.com>
Date:	Fri, 31 Oct 2014 11:12:55 +0900
From:	Masahiro Yamada <yamada.m@...panasonic.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	linux-kbuild@...r.kernel.org, Michal Marek <mmarek@...e.cz>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kbuild: collect shorthands into the top Makefile

Hi Sam,

On Wed, 29 Oct 2014 19:59:07 +0100
Sam Ravnborg <sam@...nborg.org> wrote:

> On Wed, Oct 29, 2014 at 04:27:31PM +0900, Masahiro Yamada wrote:
> > The motivation of this commit is to avoid duplicated definitions
> > of "clean" and "hdr-inst" shorthands.
> > 
> > The shorthand "clean" is defined in both the top Makefile and
> > scripts/Makefile.clean.
> > 
> > Likewise, "hdr-inst" is defined in both the top Makefile and
> > scripts/Makefile.headersinst.
> > 
> > The idea here is define and export them in the top Makefile
> > because $(srctree) is constant during the build process.
> > 
> > For consistency, "build" and "modbuiltin" should be also moved.
> 
> As a general rule the exported names are always UPPERCASE, and local variables
> are lowercase. (srctree, objtree are the exceptions).
> This patch define new lowercase variables that conflicts with this.
> 
> And it is not that logical these are picked up from the enviroment.
> Could you find a central place to define them rahter than using
> the environemnt to export them?

Maybe we can collect them into scripts/Kbuild.include
although it might be too much for Makefile.clean to include
the whole things in Kbuild.include.


Best Regards
Masahiro Yamada

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/