linux-kernel - Re: [PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141031181155.GP18557@sirena.org.uk>
Date:	Fri, 31 Oct 2014 18:11:55 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Jianqun <jay.xu@...k-chips.com>
Cc:	heiko@...ech.de, lgirdwood@...il.com, perex@...ex.cz,
	tiwai@...e.de, linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, huangtao@...k-chips.com,
	cf@...k-chips.com
Subject: Re: [PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support

On Wed, Oct 22, 2014 at 08:40:56AM +0800, Jianqun wrote:

>  config SND_SOC_ROCKCHIP_I2S
>  	tristate
> +	depends on CLKDEV_LOOKUP && SND_SOC_ROCKCHIP
> +	help
> +	  Say Y or M if you want to add support for I2S driver for Rockchip
> +	  I2S device.

You need to make this directlyuser selectable by adding some text after
the tristate as well as the rest.

> +config SND_SOC_MAX98090
> +	tristate "ASoC support max98090 device driver"
> +	depends on I2C && GPIOLIB
> +	select SND_SOC_ROCKCHIP_I2S
> +	help
> +	  Say Y or M here if you want to add support for Rockchio board using
> +	  a max98090 codec.

This needs to modify the existing MAX98090 entry, not duplicate it
(probably as a separate patch).

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)