linux-kernel - RE: [PATCH 0/5] staging: comedi: split bus support into separate modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DC148C5AA1CEBA4E87973D432B1C2D882601ABA4@P3PWEX4MB008.ex4.secureserver.net>
Date:	Fri, 31 Oct 2014 18:19:32 +0000
From:	Hartley Sweeten <HartleyS@...ionengravers.com>
To:	Ian Abbott <abbotti@....co.uk>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
CC:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/5] staging: comedi: split bus support into separate
 modules

On Friday, October 31, 2014 10:48 AM, Ian Abbott wrote:
> The Comedi core module doesn't need support for PCI, USB or PCMCIA.
> Only the low-level Comedi drivers need it.  Split the support for these
> bus types out of the core "comedi" module and into new modules,
> "comedi_pci", "comedi_usb", and "comedi_pcmcia".
>
> 1) staging: comedi: comedidev.h: remove dummy PCI support functions
> 2) staging: comedi: comedidev.h: remove some #ifdefs
> 3) staging: comedi: split out PCMCIA support into new module
> 4) staging: comedi: split out USB support into new module
> 5) staging: comedi: split out PCI support into new module

Ian,

Is this really necessary?

The pci, usb, and pcmcia support is already conditionally compiled in.
The support does get added to the main comedi module instead of
as separate modules but that shouldn't be a problem.

Regards,
Hartley

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/