linux-kernel - Re: [PATCH v3 09/15] net: dsa: Add support for switch EEPROM access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20141030.234313.2253116750470358032.davem@davemloft.net>
Date:	Thu, 30 Oct 2014 23:43:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	linux@...ck-us.net
Cc:	andrew@...n.ch, netdev@...r.kernel.org, f.fainelli@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 09/15] net: dsa: Add support for switch EEPROM access

From: Guenter Roeck <linux@...ck-us.net>
Date: Thu, 30 Oct 2014 19:53:17 -0700

> On 10/30/2014 07:40 PM, Andrew Lunn wrote:
>>> As suspected, ethtool will attempt to read a zero-length eeprom.
>>>
>>> The following patch should solve the problem. Not sure if it is worth
>>> it,
>>> though, since this will change behavior for existing drivers.
>>
>> Yes, it changes behaviour, but it does make it more consistent.
>>
>> Probably it should be up to core network people to decide if this is
>> the write fix or leave it as is.
>>
> 
> s/write/right/.
> 
> The patch shows up in the netdev patchwork. David marked it as RFC,
> so we'll see where it goes.

As per your patch, I think we should fix this to not return a zero
length eeprom when the driver doesn't support it.

If dsa behaves outside of the defined behavior of what ethtool
implementations in ethernet drivers do, then it's ok to change it
because it's a bonafide bug fix in my eyes.

So if you submit this formally, I would apply it.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/