linux-kernel - Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141101162938.GA22778@sudip-PC>
Date:	Sat, 1 Nov 2014 21:59:38 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Chen Weixiang <weixiangchen@...il.com>,
	Marek Belisko <marek.belisko@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Aybuke Ozdemir <aybuke.147@...il.com>,
	Felipe Balbi <balbi@...com>, Nicolas Thery <nthery@...il.com>,
	Greg Donald <gdonald@...il.com>,
	Daniel Dodge <danieldodgese@...il.com>,
	Wilfried Klaebe <w-lkml@...enslange-mailadresse.de>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=',
 '<' and '=='

On Sat, Nov 01, 2014 at 10:09:39PM +0800, Chen Weixiang wrote:
> On Sat, Nov 01, 2014 at 10:35:35AM +0530, Sudip Mukherjee wrote:
> > many whitespace errors in the patch.
> > checkpatch gives total: 8 errors, 23 warnings, 125 lines checked
> > 
> > thanks
> > sudip
> > 
> 
> Hi sudip,
> 
> Yes, I also run checkpatch.pl on this patch, and got several
> errors/warnings. But those errors/warnings are not related to
> spaces around '=', '<' and '==' anymore.
> 
> I thought it's better to fix one code style error/warning in
> one patch, and put the code style error/warning to Subject line.
> It's much clear, isn't it?
yes , it is . :)
i was also trying to generate a similar patch, which will not give checkpatch error,
  but it seems the original file code indention is not done with tabs. so those errors will be there if you want to keep the same indention.

thanks
sudip

> 
> Thanks.
> 
> -- 
> Best regards,
> Chen Weixiang (Alex)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/