linux-kernel - Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=', '<' and '=='

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141101052501.GH3642@sudip-PC>
Date:	Sat, 1 Nov 2014 10:55:01 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Chen Weixiang <weixiangchen@...il.com>,
	Marek Belisko <marek.belisko@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Chen Weixiang <weixiang.chen@...il.com>,
	Aybuke Ozdemir <aybuke.147@...il.com>,
	Felipe Balbi <balbi@...com>, Nicolas Thery <nthery@...il.com>,
	Greg Donald <gdonald@...il.com>,
	Daniel Dodge <danieldodgese@...il.com>,
	Wilfried Klaebe <w-lkml@...enslange-mailadresse.de>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/6] staging: ft1000: spaces required around that '=',
 '<' and '=='

On Fri, Oct 31, 2014 at 10:14:30PM -0700, Joe Perches wrote:
> On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote:
> > On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote:
> > > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c
> > > and ft1000/ft1000-pcmcia/ft1000_hw.c:
> > > ERROR: spaces required around that '=' (ctx:VxV)
> > > ERROR: spaces required around that '<' (ctx:VxV)
> > > ERROR: spaces required around that '==' (ctx:VxV)
> > > 
> > 
> > many whitespace errors in the patch.
> > checkpatch gives total: 8 errors, 23 warnings, 125 lines checked
> 
> When fixing one thing (like spacing), it's pretty
> expected to have more checkpatch errors.
> 
> It's a process, don't worry about most intermediate
> warnings when doing checkpatch cleanups.
> 
> Adding trailing spaces is not good, nearly every
> other type of message can be ignored.
> 
ok, just to verify, i thought of trying to generate a similar patch which will not give checkpatch errors.
but this patch is not applying to next-20141031.

thanks
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/