lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 01 Nov 2014 09:45:46 +0100 From: Javier Martinez Canillas <javier.martinez@...labora.co.uk> To: Doug Anderson <dianders@...omium.org>, Mark Brown <broonie@...nel.org> CC: Heiko Stuebner <heiko@...ech.de>, Chris Zhong <zyw@...k-chips.com>, Andrew Bresticker <abrestic@...omium.org>, Chanwoo Choi <cw00.choi@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com>, linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com, ijc+devicetree@...lion.org.uk, galak@...eaurora.org, carlos@...rcia.org, rdunlap@...radead.org, jkosina@...e.cz, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/2] regulator: Document binding for regulator suspend voltage Hello Doug, On 11/01/2014 04:52 AM, Doug Anderson wrote: > This patch builds upon (291d761 regulator: Document binding for > regulator suspend state for PM state) to allow setting the uV in > addition to the state at suspend time. > > Signed-off-by: Doug Anderson <dianders@...omium.org> > --- > Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt > index aaad615..4e7ed76 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > @@ -28,6 +28,8 @@ Optional properties: > - regulator-state-[mem/disk] node has following common properties: > - regulator-on-in-suspend: regulator should be on in suspend state. > - regulator-off-in-suspend: regulator should be off in suspend state. > + - regulator-suspend-microvolt: regulator should be set to this voltage > + in suspend. The patch looks good to me: Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk> On thing I wonder is if the binding should say that the suspend voltage is independent of the runtime one and it may be outside of the runtime range? Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists