linux-kernel - Re: [PATCH v3 0/4] Fixes for ALPS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54563C5F.10702@redhat.com>
Date:	Sun, 02 Nov 2014 15:14:55 +0100
From:	Hans de Goede <hdegoede@...hat.com>
To:	Pali Rohár <pali.rohar@...il.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Yunkang Tang <yunkang.tang@...alps.com>,
	Tommy Will <tommywill2011@...il.com>
CC:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/4] Fixes for ALPS driver

Hi,

On 11/02/2014 12:25 AM, Pali Rohár wrote:
> This patch series tries to fix problems with ALPS dualpoint devices on Dell
> Latitude laptops which are probably caused by bugs in Dell BIOS, Dell EC or
> in ALPS touchpad firmware itself.
> 
> Root of problems is yet unknown but at least this patch series could eliminate
> reporting bogus data to userspace.
> 
> Reported bugs:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1258837
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1320022
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1272624
> https://bugzilla.redhat.com/show_bug.cgi?id=1145954
> 
> Pali Rohár (4):
>   input: alps: Do not try to parse data as 3 bytes packet when driver
>     is out of sync
>   input: alps: Allow 2 invalid packets without resetting device
>   input: alps: For protocol V3, do not process data when last packet's
>     bit7 is set
>   input: alps: Fix trackstick detection
> 
>  drivers/input/mouse/alps.c |  113 +++++++++++++++++++++++++++++++-------------
>  1 file changed, 80 insertions(+), 33 deletions(-)

Thanks for working on this, patches 1-3 are:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Patch 4 is too much work to review on a Sunday :), so I'll leave
reviewing it to Dmitry.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/