linux-kernel - Re: [PATCH v2 4/6] hw_random: fix unregister race.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141102151421.GB31178@air.redhat.com>
Date:	Sun, 2 Nov 2014 23:14:21 +0800
From:	Amos Kong <akong@...hat.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	virtualization@...ts.linux-foundation.org, kvm@...r.kernel.org,
	m@...s.ch, mpm@...enic.com, amit.shah@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/6] hw_random: fix unregister race.

On Sun, Nov 02, 2014 at 11:08:09PM +0800, Herbert Xu wrote:
> On Sun, Nov 02, 2014 at 11:06:13PM +0800, Amos Kong wrote:
> > On Fri, Oct 31, 2014 at 03:23:21PM +0800, Herbert Xu wrote:
> > > On Fri, Oct 31, 2014 at 10:28:00AM +1030, Rusty Russell wrote:
> > > > Herbert Xu <herbert@...dor.apana.org.au> writes:
> > > > > On Thu, Sep 18, 2014 at 08:37:45PM +0800, Amos Kong wrote:
> > > > >> From: Rusty Russell <rusty@...tcorp.com.au>
> > > > >> 
> > > > >> The previous patch added one potential problem: we can still be
> > > > >> reading from a hwrng when it's unregistered.  Add a wait for zero
> > > > >> in the hwrng_unregister path.
> > > > >> 
> > > > >> Signed-off-by: Rusty Russell <rusty@...tcorp.com.au>
> > > > >
> > > > > You totally corrupted Rusty's patch.  If you're going to repost
> > > > > his series you better make sure that you've got the right patches.
> > > > >
> > > > > Just as well though as it made me think a little more about this
> > > > > patch :)
> > > > 
> > > > OK Amos, can you please repost the complete series?
> > > 
> > > Please fix the unregister race I identified first.
> > 
> > Ok, I redownload the patches from https://patchwork.kernel.org/project/LKML/list/?submitter=5
> > and rebase fixes of me and rusty on it. I will post a V4 later. Thanks.
> 
> Please fix the unregister race I pointed out before doing a v4.

Thanks for the remind, I got it right now  :-)

-- 
			Amos.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/