| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 02 Nov 2014 18:24:30 -0500 (EST) From: David Miller <davem@...emloft.net> To: clemens@...isch.de Cc: sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] sparc64: Add preprocessor symbols for PAGE_* pgprot_t values. From: Clemens Ladisch <clemens@...isch.de> Date: Sun, 02 Nov 2014 21:15:12 +0100 > Kernel code assumes that the PAGE_* values are preprocessor symbols, and > that therefore arch support can be checked for with #ifdef. > > At the moment, sparc64 does not implement any of the symbols checked > for, so these checks happen to work. > > To prevent potential breakage when another #ifdef check is added or when > sparc64 implements another PAGE_ value, make such #ifdef checks work by > adding preprocessor symbols on top of the PAGE_* variables. > > Signed-off-by: Clemens Ladisch <clemens@...isch.de> "This change actually doesn't have any effect, and doesn't matter, so let's make this change." I really don't buy this. I'd also rather the kernel use Kconfig based symbols to detect for arch availability of feature X or Y, assuming things are CPP symbols is very fragile at best. I'm not applying this, sorry. I mean, you didn't even bother to mention what symbol this does matter for. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists