linux-kernel - Re: [PATCH] Documentation: Restrict TSC test code to x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5455E871.7080700@suse.de>
Date:	Sun, 02 Nov 2014 09:16:49 +0100
From:	Alexander Graf <agraf@...e.de>
To:	"Matwey V. Kornilov" <matwey.kornilov@...il.com>
CC:	Jonathan Corbet <corbet@....net>,
	Peter Foley <pefoley2@...oley.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Jiri Kosina <jkosina@...e.cz>,
	Randy Dunlap <rdunlap@...radead.org>,
	"afaerber@...e.de" <afaerber@...e.de>
Subject: Re: [PATCH] Documentation: Restrict TSC test code to x86



On 02.11.14 08:46, Matwey V. Kornilov wrote:
> I wish I knew. We need KBuild guru to ask how to take into account
> host architecture.

Hrm. At least this patch makes things more consistent with the other
Documentation makefiles:

Documentation/timers/Makefile:hostprogs-$(CONFIG_X86) := hpet_example
Documentation/vDSO/Makefile:hostprogs-$(CONFIG_X86) :=
vdso_standalone_test_x86

But I agree, it is wrong in general - hostprogs should make sure the
host arch matches.

We could maybe just evaluate the host uname output:

  ifeq ($(shell uname -m),x86_64)
    hostprogs-$(CONFIG_X86) := ...
  endif

Then we're double safe ;). Not sure how to easily add x86 to the mix as
well here, but I'm not sure anyone cares. Do people still compile on
32bit x86 hosts? And expect Documentation/ examples to build?


Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/