linux-kernel - Re: [PATCH 3/8] perf tools: Get rid of unused dsos__hit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Nov 2014 16:39:59 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>, David Ahern <dsahern@...il.com>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 3/8] perf tools: Get rid of unused dsos__hit_all()

Hi Adrian,

On Mon, Nov 3, 2014 at 4:35 PM, Adrian Hunter <adrian.hunter@...el.com> wrote:
> On 03/11/14 09:27, Namhyung Kim wrote:
>> The dsos__hit_all() and its friends are not used anywhere.  Let's get
>> rid of them.
>
> They were added for Intel PT preparation.  Intel PT is still on its way,
> so they are still needed.  Note the commit was:
>
> commit 1f625b0b3dd641b74ba21640a1fea19a3dd893a2
> Author: Adrian Hunter <adrian.hunter@...el.com>
> Date:   Tue Jul 22 16:17:23 2014 +0300
>
>     perf tools: Add dsos__hit_all()
>
>     Add ability to mark all dsos as hit.
>
>     This is needed in the case of Instruction Tracing.  It takes so long to
>     decode an Instruction Trace that it is not worth doing just to determine
>     which dsos are hit.  A later patch takes this into use.

Oops, didn't notice.  Sorry for not checking the commit log.  So how
about moving it into util/build-id.c then?

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/