linux-kernel - Re: [GIT PULL] please pull infiniband.git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <545735A4.6060107@dev.mellanox.co.il>
Date:	Mon, 03 Nov 2014 09:58:28 +0200
From:	Sagi Grimberg <sagig@....mellanox.co.il>
To:	Dave Airlie <airlied@...il.com>, Roland Dreier <roland@...nel.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-rdma@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] please pull infiniband.git

On 11/2/2014 10:06 PM, Dave Airlie wrote:
> On 17 October 2014 08:52, Roland Dreier <roland@...nel.org> wrote:
>> Hi Linus,
>>
>> Please pull from
>>
>>      git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus
>>
>> ----------------------------------------------------------------
>> Main set of InfiniBand/RDMA updates for 3.18 merge window:
>>
>>   - Large set of iSER initiator improvements
>>   - Hardware driver fixes for cxgb4, mlx5 and ocrdma
>>   - Small fixes to core midlayer
>>
>
> building on 32-bit x86.
>
>   CC [M]  drivers/infiniband/ulp/iser/iser_verbs.o
> /home/airlied/devel/kernel/linux-2.6/drivers/infiniband/ulp/iser/iser_verbs.c:
> In function ‘iser_handle_comp_error’:
> /home/airlied/devel/kernel/linux-2.6/drivers/infiniband/ulp/iser/iser_verbs.c:1171:33:
> warning: cast to pointer from integer of different size
> [-Wint-to-pointer-cast]
>    if (is_iser_tx_desc(iser_conn, (void *)wc->wr_id)) {
>                                   ^
> /home/airlied/devel/kernel/linux-2.6/drivers/infiniband/ulp/iser/iser_verbs.c:1172:31:
> warning: cast to pointer from integer of different size
> [-Wint-to-pointer-cast]
>     struct iser_tx_desc *desc = (struct iser_tx_desc *)wc->wr_id;
>                                 ^
> /home/airlied/devel/kernel/linux-2.6/drivers/infiniband/ulp/iser/iser_verbs.c:
> In function ‘iser_handle_wc’:
> /home/airlied/devel/kernel/linux-2.6/drivers/infiniband/ulp/iser/iser_verbs.c:1198:14:
> warning: cast to pointer from integer of different size
> [-Wint-to-pointer-cast]
>      rx_desc = (struct iser_rx_desc *)wc->wr_id;
>                ^
> /home/airlied/devel/kernel/linux-2.6/drivers/infiniband/ulp/iser/iser_verbs.c:1203:14:
> warning: cast to pointer from integer of different size
> [-Wint-to-pointer-cast]
>      tx_desc = (struct iser_tx_desc *)wc->wr_id;
>                ^
>
> Not sure anyone would ever want to run this code on 32-bit boxes, but
> I'm a bit worried if wr_id is a 64-bit value, and we encode it into a
> 32-bit pointer, you'd always lose the top 32-bits.
>

Hey Dave,

This was addressed in: 
http://marc.info/?l=linux-rdma&m=141448978030924&w=2 (part of iser fixes 
for 3.18-rc).

Thanks!

Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/