linux-kernel - Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1415004303.407.11.camel@mm-sol.com>
Date:	Mon, 03 Nov 2014 10:45:03 +0200
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Peter Meerwald <pmeerw@...erw.net>
Cc:	Hartmut Knaack <knaack.h@....de>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver


On Fri, 2014-10-31 at 21:48 +0100, Peter Meerwald wrote:
> > Ivan T. Ivanov schrieb am 22.10.2014 16:13:
> > > The current ADC is peripheral of Qualcomm SPMI PMIC chips. It has
> > > 16 bits resolution and register space inside PMIC accessible across
> > > SPMI bus.
> > >
> > > The driver registers itself through IIO interface.
> > Pretty much there, just one question I would like to double-check: The CPU of these chips is 
> Little Endian, right?
> > Annoyingly, you introduced a small typo in this revision, but that alone doesn't qualify for a 
> new revision. A separate patch fixing it would probably be best. See inline.
> 
> some minor comments below

Thanks, will fix them. IIO maintainers, what do you
prefer, new version or fallow-up patch?

Regards,
Ivan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/