linux-kernel - Re: [PATCH] USB: simple: add Google simple serial SubClass support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141103085139.GD31358@localhost>
Date:	Mon, 3 Nov 2014 09:51:39 +0100
From:	Johan Hovold <johan@...nel.org>
To:	Anton Staaf <robotboy@...omium.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Johan Hovold <jhovold@...il.com>,
	Benson Leung <bleung@...omium.org>,
	Olof Johansson <olofj@...omium.org>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: simple: add Google simple serial SubClass support

On Thu, Oct 30, 2014 at 09:54:54PM -0700, Anton Staaf wrote:
> On Thu, Oct 30, 2014 at 7:33 AM, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > On Wed, Oct 29, 2014 at 02:21:56PM -0700, Anton Staaf wrote:
> > > Add support for Google devices that export simple serial
> > > interfaces using the vendor specific SubClass/Protocol pair
> > > 0x50/0x01.
> > >
> > > Signed-off-by: Anton Staaf <robotboy@...omium.org>
> > >
> > > ---
> > >  drivers/usb/serial/usb-serial-simple.c | 11 +++++++++++
> > >  1 file changed, 11 insertions(+)
> > >
> > > diff --git a/drivers/usb/serial/usb-serial-simple.c b/drivers/usb/serial/usb-serial-simple.c
> > > index fb79775..85bb973 100644
> > > --- a/drivers/usb/serial/usb-serial-simple.c
> > > +++ b/drivers/usb/serial/usb-serial-simple.c
> > > @@ -8,6 +8,7 @@
> > >   * Copyright (C) 2010 Zilogic Systems <code@...ogic.com>
> > >   * Copyright (C) 2013 Wei Shuai <cpuwolf@...il.com>
> > >   * Copyright (C) 2013 Linux Foundation
> > > + * Copyright (C) 2014 Google, Inc.
> > >   *
> > >   *   This program is free software; you can redistribute it and/or
> > >   *   modify it under the terms of the GNU General Public License version
> >
> > Based on advice from my lawyer, a change this size does not warrent a
> > copyright notice at the top of a file.  If your lawyers feel otherwise,
> > please let me know and I will be glad to discuss it with them.
> >
> > So, care to resend this without this change to the file?
> >
> > thanks,
> >
> > greg k-h
> 
> Sigh, sorry for the top posted HTML junk previously, turns out the
> gmail app for android doesn't "do the right thing"...
> 
> But yes, I'm happy to send along a version without copyright, I don't
> see any problem with that.  Looks like it will
> have to wait until Monday as I don't have things set up at home to
> send the patch as robotboy@...omium.org.  :)

Please also make sure to generate the patch against v3.18-rc (the one
you sent would not apply).

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/