linux-kernel - Re: [PATCH 2/2] ALSA: echoaudio: remove all snd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hbnoo39j3.wl-tiwai@suse.de>
Date:	Mon, 03 Nov 2014 10:42:24 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ALSA: echoaudio: remove all snd_printk

At Mon,  3 Nov 2014 14:16:23 +0530,
Sudip Mukherjee wrote:
> 
> @@ -98,7 +99,7 @@ static int init_hw(struct echoaudio *chip, u16 device_id, u16 subdevice_id)
>  				ECHOCAPS_HAS_DIGITAL_MODE_SPDIF_OPTICAL |
>  				ECHOCAPS_HAS_DIGITAL_MODE_ADAT;
>  
> -	DE_INIT(("init_hw done\n"));
> +	dev_info(chip->card->dev, "init_hw done\n");

This (and the rest of all dev_info() in your patch) should be
dev_dbg().  They are no really useful information to be shown at each
time the module is loaded.  ("init_hw done"?  Yeah, why not, when the
module is loaded successfully :)


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/