linux-kernel - Re: [PATCH v3] mmc: dw_mmc: add support for the other bit of sdio interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3540679.aQ4QUeBEJd@diego>
Date:	Mon, 03 Nov 2014 11:23:52 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Jaehoon Chung <jh80.chung@...sung.com>
Cc:	Addy Ke <addy.ke@...k-chips.com>, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	rdunlap@...radead.org, tgih.jun@...sung.com, chris@...ntf.net,
	ulf.hansson@...aro.org, dinguyen@...era.com, olof@...om.net,
	dianders@...omium.org, sonnyrao@...omium.org,
	huangtao@...k-chips.com, devicetree@...r.kernel.org,
	hl@...k-chips.com, linux-doc@...r.kernel.org, yzq@...k-chips.com,
	zyw@...k-chips.com, zhangqing@...k-chips.com,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	kever.yang@...k-chips.com, lintao@...k-chips.com,
	linux-rockchip@...ts.infradead.org, xjq@...k-chips.com,
	zhenfu.fang@...k-chips.com, chenfen@...k-chips.com,
	cf@...k-chips.com, hj@...k-chips.com,
	linux-arm-kernel@...ts.infradead.org, zyf@...k-chips.com
Subject: Re: [PATCH v3] mmc: dw_mmc: add support for the other bit of sdio interrupt

Hi Jaehoon,

Am Montag, 3. November 2014, 17:59:58 schrieb Jaehoon Chung:
> Hi, Addy.
> 
> On 11/03/2014 10:20 AM, Addy Ke wrote:
> > The bit of sdio interrupt is 16 in designware implementation,
> > but it is 24 on Rockchip SoCs.This patch add sdio_id0 for the
> > number of slot0 in the SDIO interrupt registers.
> > 
> > Signed-off-by: Addy Ke <addy.ke@...k-chips.com>
> > ---
> > Changes in v2:
> > - rebase on http://git.linaro.org/git/people/ulf.hansson/mmc.git, next
> > branch Changes in v3:
> > - Remove dts for sdio_id0, just replace this with 8, suggested by Doug
> > - Change to support all Rockchip Socs, suggested by Heiko
> > 
> >  drivers/mmc/host/dw_mmc-rockchip.c | 10 ++++++++++
> >  drivers/mmc/host/dw_mmc.c          | 12 +++++++-----
> >  drivers/mmc/host/dw_mmc.h          |  2 ++
> >  include/linux/mmc/dw_mmc.h         |  3 +++
> >  4 files changed, 22 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/mmc/host/dw_mmc-rockchip.c
> > b/drivers/mmc/host/dw_mmc-rockchip.c index bbb4ec3..b997c8f 100644
> > --- a/drivers/mmc/host/dw_mmc-rockchip.c
> > +++ b/drivers/mmc/host/dw_mmc-rockchip.c
> > @@ -68,14 +68,24 @@ static void dw_mci_rk3288_set_ios(struct dw_mci *host,
> > struct mmc_ios *ios)> 
> >  	}
> >  
> >  }
> > 
> > +static int dw_mci_rockchip_parse_dt(struct dw_mci *host)
> > +{
> > +	/* It is slot 8 on Rockchip SoCs */
> > +	host->sdio_id0 = 8;
> > +
> > +	return 0;
> > +}
> 
> Well, function is "__parse_dt__", but this function don't parse anything.
> If All rockchip soc is supported, i think that it can be located to other
> place.

do you have a suggestion for a location?

The only alternative I can see right now would be using the init-hook in 
dw_mci_drv_data or adding a new field to it holding the slot-offset.
[with using the init-hook being my personal preference of the two]


Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/