linux-kernel - Re: [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141103122948.GI3815@sirena.org.uk>
Date:	Mon, 3 Nov 2014 12:29:48 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Javier Martinez Canillas <javier.martinez@...labora.co.uk>
Cc:	Doug Anderson <dianders@...omium.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Chris Zhong <zyw@...k-chips.com>,
	Andrew Bresticker <abrestic@...omium.org>,
	Chanwoo Choi <cw00.choi@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, lgirdwood@...il.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] regulator: of: Add support for parsing microvolts
 for suspend state

On Sat, Nov 01, 2014 at 09:49:42AM +0100, Javier Martinez Canillas wrote:
> On 11/01/2014 04:52 AM, Doug Anderson wrote:

> > +
> >  		of_node_put(suspend_np);
> >  		suspend_state = NULL;
> >  		suspend_np = NULL;

> Looks good to me.

> Reviewed-by: Javier Martinez Canillas <javier.martinez@...labora.co.uk>

If you're reviewing something please don't quote the entire patch, the
same rule applies as always - just include relevant context - and
especially don't include your one line of content at the very end of the
patch.  Otherwise people have to page through the entire thing to find
what you've said (if they don't get fed up first).

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)