linux-kernel - Re: [PATCH RFC v2 8/8] ARM: zynq: DT: Add pinctrl information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZD+wqfxLxMJ+WGvAmaV+XL6bCcLFGD4BuB-0KXum+D_w@mail.gmail.com>
Date:	Mon, 3 Nov 2014 15:40:21 +0100
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Sören Brinkmann <soren.brinkmann@...inx.com>
Cc:	Michal Simek <michal.simek@...inx.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Steffen Trumtrar <s.trumtrar@...gutronix.de>
Subject: Re: [PATCH RFC v2 8/8] ARM: zynq: DT: Add pinctrl information

On Sun, Nov 2, 2014 at 9:20 PM, Sören Brinkmann
<soren.brinkmann@...inx.com> wrote:
(...)
>                 common {
>                         groups = "uart1_10_grp";
>                         function = "uart1";
>                         bias-pull-up = <0>;
>                         slew-rate = <0>;
>                         io-standard = <1>;
>                 };
>
>                 rx {
>                         pins = "MIO49";
>                         bias-high-impedance = <1>;
>                 };
>
>                 tx {
>                         pins = "MIO48";
>                         bias-high-impedance = <0>;
>                 };
(...)
>                 common {
>                         groups = "uart1_10_grp";
>                         function = "uart1";
>                 };
>
>                 rx {
>                         pins = "MIO49";
>                         slew-rate = <0>;
>                         io-standard = <1>;
>                         bias-high-impedance;
>                 };
>
>                 tx {
>                         pins = "MIO48";
>                         slew-rate = <0>;
>                         io-standard = <1>;
>                 };
>         };
>
> In a nutshell, yes, it's possible to work without the arguments for
> pull-up or tri-state. But it adds complexity in the driver and the DT
> description.

But isn't it obvious that the latter is easier for a human to read
and understand (and not misunderstand) and remember readability
of config is one of the design goals of DT...

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/