linux-kernel - Re: [PATCH] mfd: twl4030-power: Fix regression with missing compatible flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141103160309.GC10544@x1>
Date:	Mon, 3 Nov 2014 16:03:09 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Tony Lindgren <tony@...mide.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	"Dr. H. Nikolaus Schaller" <hns@...delico.com>,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org
Subject: Re: [PATCH] mfd: twl4030-power: Fix regression with missing
 compatible flag

On Sun, 02 Nov 2014, Tony Lindgren wrote:

> Commit e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset
> configuration") accidentally removed the compatible flag for
> "ti,twl4030-power" that should be there as documented in the
> binding.
> 
> If "ti,twl4030-power" only the poweroff configuration is done
> by the driver.
> 
> Fixes: e7cd1d1eb16f ("mfd: twl4030-power: Add generic reset configuration")
> Cc: stable@...r.kernel.org # v3.16+
> Reported-by: "Dr. H. Nikolaus Schaller" <hns@...delico.com>
> Signed-off-by: Tony Lindgren <tony@...mide.com>

Applied, thanks.

> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -831,6 +831,9 @@ static struct twl4030_power_data osc_off_idle = {
>  
>  static struct of_device_id twl4030_power_of_match[] = {
>  	{
> +		.compatible = "ti,twl4030-power",
> +	},
> +	{
>  		.compatible = "ti,twl4030-power-reset",
>  		.data = &omap3_reset,
>  	},

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/