linux-kernel - Re: [PATCH] mfd: db8500-prcmu: check return of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20141103164506.GA12011@x1>
Date:	Mon, 3 Nov 2014 16:45:06 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Pramod Gurav <pramod.gurav@...rtplayin.com>
Cc:	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] mfd: db8500-prcmu: check return of devm_ioremap for error

On Mon, 03 Nov 2014, Lee Jones wrote:

> On Thu, 30 Oct 2014, Pramod Gurav wrote:
> 
> > Error check around return value of devm_ioremap is missing. Add the same
> > to avoid NULL pointer dereference.
> > 
> > Cc: Linus Walleij <linus.walleij@...aro.org>
> > Cc: Samuel Ortiz <sameo@...ux.intel.com>
> > Cc: Lee Jones <lee.jones@...aro.org>
> > Signed-off-by: Pramod Gurav <pramod.gurav@...rtplayin.com>
> > ---
> >  drivers/mfd/db8500-prcmu.c |    5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> > index 193cf16..89ae8bf 100644
> > --- a/drivers/mfd/db8500-prcmu.c
> > +++ b/drivers/mfd/db8500-prcmu.c
> > @@ -3167,6 +3167,11 @@ static int db8500_prcmu_probe(struct platform_device *pdev)
> >  	}
> >  	tcdm_base = devm_ioremap(&pdev->dev, res->start,
> >  			resource_size(res));
> > +	if (!tcdm_base) {
> > +		dev_err(&pdev->dev,
> > +			"failed to ioremap prcmu-tcdm register memory\n");
> > +		return -ENOENT;
> 
> No such file or directory?  I think not.
> 
> Changed to -ENOMEM and applied with Linus' Ack.

Slight change of plan, as it looks like all of the return paths were
bogus.  Patch sent instead.

> > +	}
> >  
> >  	/* Clean up the mailbox interrupts after pre-kernel code. */
> >  	writel(ALL_MBOX_BITS, PRCM_ARM_IT1_CLR);
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/