linux-kernel - Re: [PATCH v2 1/2] ALSA: echoaudio: add reference of struct echoaudio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1415036747.17743.24.camel@perches.com>
Date:	Mon, 03 Nov 2014 09:45:47 -0800
From:	Joe Perches <joe@...ches.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Takashi Iwai <tiwai@...e.de>, Jaroslav Kysela <perex@...ex.cz>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] ALSA: echoaudio: add reference of struct
 echoaudio

On Mon, 2014-11-03 at 22:22 +0530, Sudip Mukherjee wrote:
> On Mon, Nov 03, 2014 at 07:08:08AM -0800, Joe Perches wrote:
[]
> > ftrace exists and is generic.
> > 
> > Several of these seem to be function tracing
> > style uses and should just be deleted instead.
> 
> function tracing style uses means?

ftrace

see:

Documentation/trace/ftrace.txt
Documentation/trace/ftrace-design.txt

> there are some prints which are printing the function name while printing the debug message.
> are those function tracing style uses??

A debug message should generally not be emitting a
message just for the sake of documenting when a
function is entered/left.

Sometimes that is useful for initial debugging, but
almost always those debugging printks should not be
left in the code that is pushed to kernel.org.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/