| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CABuKBeLYMbD-dV_25FJd_NE1RgfVkgF+SoCiAx9O9jKUUAcexA@mail.gmail.com>
Date: Mon, 3 Nov 2014 18:53:14 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: "Joe.C" <yingjoe.chen@...iatek.com>
Cc: Rob Herring <robh+dt@...nel.org>, arm@...nel.org,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Russell King <linux@....linux.org.uk>,
Olof Johansson <olof@...om.net>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
srv_heupstream <srv_heupstream@...iatek.com>,
Yingjoe Chen <yingjoe.chen@...il.com>,
Hsien-Chun Yen <hc.yen@...iatek.com>,
huang eddie <eddie.huang@...iatek.com>,
Nathan Chung <nathan.chung@...iatek.com>,
Yuhau Chen <yh.chen@...iatek.com>,
Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH v4 1/8] ARM: mediatek: Add basic support for mt8127
2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@...iatek.com>:
> From: "Joe.C" <yingjoe.chen@...iatek.com>
>
> This adds a basic dtsi for MT8127 SoC.
>
> Signed-off-by: Joe.C <yingjoe.chen@...iatek.com>
> ---
> arch/arm/boot/dts/mt8127.dtsi | 93 +++++++++++++++++++++++++++++++++++++++
> arch/arm/mach-mediatek/mediatek.c | 1 +
> 2 files changed, 94 insertions(+)
> create mode 100644 arch/arm/boot/dts/mt8127.dtsi
>
> diff --git a/arch/arm/boot/dts/mt8127.dtsi b/arch/arm/boot/dts/mt8127.dtsi
> new file mode 100644
> index 0000000..25c9f69
> --- /dev/null
> +++ b/arch/arm/boot/dts/mt8127.dtsi
> @@ -0,0 +1,93 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Joe.C <yingjoe.chen@...iatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include "skeleton64.dtsi"
Cortex a7 is 32 bits, right? So why do you use skeleton64.dtsi?
> +
> +/ {
> + compatible = "mediatek,mt8127";
> + interrupt-parent = <&gic>;
> +
> + cpus {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a7";
> + reg = <0x0>;
> + };
> + cpu@1 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a7";
> + reg = <0x1>;
> + };
> + cpu@2 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a7";
> + reg = <0x2>;
> + };
> + cpu@3 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a7";
> + reg = <0x3>;
> + };
> +
> + };
> +
> + clocks {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + compatible = "simple-bus";
> + ranges;
> +
> + system_clk: dummy13m {
> + compatible = "fixed-clock";
> + clock-frequency = <13000000>;
> + #clock-cells = <0>;
> + };
> +
> + rtc_clk: dummy32k {
> + compatible = "fixed-clock";
> + clock-frequency = <32000>;
> + #clock-cells = <0>;
> + };
> + };
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + compatible = "simple-bus";
> + ranges;
> +
> + timer: timer@...08000 {
> + compatible = "mediatek,mt8127-timer", "mediatek,mt6577-timer";
> + reg = <0 0x10008000 0 0x80>;
This should be "reg = <0x10008000 0x80>;" right?
Same in mt8135.dtsi
> + interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&system_clk>, <&rtc_clk>;
> + clock-names = "system-clk", "rtc-clk";
> + };
> +
> + gic: interrupt-controller@...11000 {
> + compatible = "arm,cortex-a7-gic";
> + interrupt-controller;
> + #interrupt-cells = <3>;
> + reg = <0 0x10211000 0 0x1000>,
> + <0 0x10212000 0 0x1000>,
> + <0 0x10214000 0 0x2000>,
> + <0 0x10216000 0 0x2000>;
> + };
> + };
> +};
> diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
> index f2acf07..7f478ce 100644
> --- a/arch/arm/mach-mediatek/mediatek.c
> +++ b/arch/arm/mach-mediatek/mediatek.c
> @@ -19,6 +19,7 @@
>
> static const char * const mediatek_board_dt_compat[] = {
> "mediatek,mt6589",
> + "mediatek,mt8127",
> NULL,
> };
>
> --
> 1.8.1.1.dirty
>
--
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists