[<prev] [next>] [day] [month] [year] [list]
Message-ID: <CABuKBeJR+iCw_gZeq_SbZB2CtESJ5FX3jOZ1OwzELRcBH+jn9A@mail.gmail.com>
Date: Mon, 3 Nov 2014 18:58:46 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: "Joe.C" <yingjoe.chen@...iatek.com>
Cc: Rob Herring <robh+dt@...nel.org>, arm@...nel.org,
Pawel Moll <pawel.moll@....com>,
Mark Rutland <mark.rutland@....com>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Kumar Gala <galak@...eaurora.org>,
Russell King <linux@....linux.org.uk>,
Olof Johansson <olof@...om.net>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
srv_heupstream <srv_heupstream@...iatek.com>,
Yingjoe Chen <yingjoe.chen@...il.com>,
Hsien-Chun Yen <hc.yen@...iatek.com>,
huang eddie <eddie.huang@...iatek.com>,
Nathan Chung <nathan.chung@...iatek.com>,
Yuhau Chen <yh.chen@...iatek.com>,
Sascha Hauer <kernel@...gutronix.de>
Subject: Re: [PATCH v4 4/8] ARM: mediatek: add dts for MT8135 evaluation board.
2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@...iatek.com>:
> From: "Joe.C" <yingjoe.chen@...iatek.com>
>
> Evbp1 is a tablet evaluation board based on MT8135 SoC.
>
> Signed-off-by: Joe.C <yingjoe.chen@...iatek.com>
> ---
> arch/arm/boot/dts/mt8135-evbp1.dts | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
> create mode 100644 arch/arm/boot/dts/mt8135-evbp1.dts
>
> diff --git a/arch/arm/boot/dts/mt8135-evbp1.dts b/arch/arm/boot/dts/mt8135-evbp1.dts
> new file mode 100644
> index 0000000..cba80b8
> --- /dev/null
> +++ b/arch/arm/boot/dts/mt8135-evbp1.dts
> @@ -0,0 +1,24 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Joe.C <yingjoe.chen@...iatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +/dts-v1/;
> +#include "mt8135.dtsi"
> +
> +/ {
> + model = "mediatek,mt8135-evbp1", "mediatek,mt8135";
Same here, you switched model and compatible property. Please provide
both of them.
> +
> + memory {
> + reg = <0 0x80000000 0 0x40000000>;
> + };
> +};
> --
> 1.8.1.1.dirty
>
--
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists