linux-kernel - Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141103180150.GA10164@roeck-us.net>
Date:	Mon, 3 Nov 2014 10:01:50 -0800
From:	Guenter Roeck <linux@...ck-us.net>
To:	Felipe Balbi <balbi@...com>
Cc:	myungjoo.ham@...sung.com, cw00.choi@...sung.com,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	nsekhar@...com, grant.likely@...aro.org,
	George Cherian <george.cherian@...com>
Subject: Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc
 API's

On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote:
> From: George Cherian <george.cherian@...com>
> 
> Convert the driver to use gpiod_* API's.
> 
> Reviewed-by: Roger Quadros <rogerq@...com>
> Signed-off-by: George Cherian <george.cherian@...com>
> Signed-off-by: Sekhar Nori <nsekhar@...com>
> Signed-off-by: Felipe Balbi <balbi@...com>
> ---

I think it might be useful and appropriate to explain that and why
you remove support for active-low pins, instead of hiding it in a
seemingly unrelated patch.

Also, since you don't use the platform data flag anymore, you might
as well remove it to give out-of-tree users a fair warning. Overall,
it might be easier to just revert the patch introducing it (5bfbdc9caa7)
before converting extcon to gpiod.

I am just glad that we stopped using extcon for other reasons ;-)

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/