linux-kernel - Re: [PATCH v2 2/3] x86_64,vsyscall: Rewrite comment and clean up headers in vsyscall code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Nov 2014 21:31:01 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andy Lutomirski <luto@...capital.net>
cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Josh Triplett <josh@...htriplett.org>,
	Ingo Molnar <mingo@...nel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Subject: Re: [PATCH v2 2/3] x86_64,vsyscall: Rewrite comment and clean up
 headers in vsyscall code

On Wed, 29 Oct 2014, Andy Lutomirski wrote:

> vsyscall_64.c is just vsyscall emulation.  Tidy it up accordingly.
> 
> If my comment editing offends anyone, let me know and I can fix it.
> 
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
> Signed-off-by: Andy Lutomirski <luto@...capital.net>
> ---
>  arch/x86/kernel/vsyscall_64.c | 51 +++++++++++++++----------------------------
>  1 file changed, 18 insertions(+), 33 deletions(-)
> 
> diff --git a/arch/x86/kernel/vsyscall_64.c b/arch/x86/kernel/vsyscall_64.c
> index 2d912629c96e..ee622f8183f3 100644
> --- a/arch/x86/kernel/vsyscall_64.c
> +++ b/arch/x86/kernel/vsyscall_64.c
> @@ -1,52 +1,37 @@
>  /*
> - *  Copyright (C) 2001 Andrea Arcangeli <andrea@...e.de> SuSE
> - *  Copyright 2003 Andi Kleen, SuSE Labs.
> + * Mostly copyright (c) 2012-2014 Andy Lutomirski <luto@...capital.net>

We usualy leave the old copyright notices around even if the code
which is related to them has been removed more or less completely.

So I change this to:

/*
 * Copyright (c) 2012-2014 Andy Lutomirski <luto@...capital.net>
 *
 * Based on the original implementation:
 *  Copyright (C) 2001 Andrea Arcangeli <andrea@...e.de> SuSE
 *  Copyright 2003 Andi Kleen, SuSE Labs.

and apply the whole lot.

Thanks,

	tglx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/