linux-kernel - Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc API's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20141103204304.GC17356@saruman>
Date:	Mon, 3 Nov 2014 14:43:04 -0600
From:	Felipe Balbi <balbi@...com>
To:	Guenter Roeck <linux@...ck-us.net>
CC:	Felipe Balbi <balbi@...com>, <myungjoo.ham@...sung.com>,
	<cw00.choi@...sung.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	<nsekhar@...com>, <grant.likely@...aro.org>,
	George Cherian <george.cherian@...com>
Subject: Re: [PATCH 1/4] extcon: gpio: Convert the driver to use gpio desc
 API's

Hi,

On Mon, Nov 03, 2014 at 10:51:08AM -0800, Guenter Roeck wrote:
> On Mon, Nov 03, 2014 at 12:06:02PM -0600, Felipe Balbi wrote:
> > On Mon, Nov 03, 2014 at 10:01:50AM -0800, Guenter Roeck wrote:
> > > On Mon, Nov 03, 2014 at 10:32:27AM -0600, Felipe Balbi wrote:
> > > > From: George Cherian <george.cherian@...com>
> > > > 
> > > > Convert the driver to use gpiod_* API's.
> > > > 
> > > > Reviewed-by: Roger Quadros <rogerq@...com>
> > > > Signed-off-by: George Cherian <george.cherian@...com>
> > > > Signed-off-by: Sekhar Nori <nsekhar@...com>
> > > > Signed-off-by: Felipe Balbi <balbi@...com>
> > > > ---
> > > 
> > > I think it might be useful and appropriate to explain that and why
> > > you remove support for active-low pins, instead of hiding it in a
> > > seemingly unrelated patch.
> > 
> > removed ? why removed ? gpio descs handle that for you, read the source
> > code.
> > 
> Well, it for sure looks like it. Care to explain that in the patch,
> as well as how the platform data flag is used ?

I'll leave that to $author, I just cherry-picked and tested them.
Certainly that commit log needs some love.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)